Re: [PATCH v06 09/36] uapi asm-generic/sembuf.h: include asm/posix_types.h and asm/ipcbuf.h

[Dmitry V. Levin]

On Sun, Aug 06, 2017 at 06:44:00PM +0200, Mikko Rapeli wrote:
> Fixes userspace compilation errors like:
> 
> error: field âmsg_permâ has incomplete type
> struct ipc64_perm msg_perm;
> error: unknown type name â__kernel_ulong_tâ
> 
> Signed-off-by: Mikko Rapeli <mikko.rapeli@xxxxxx>
> Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: H.J. Lu <hjl.tools@xxxxxxxxx>
> Cc: H. Peter Anvin <hpa@xxxxxxxxx>
> ---
>  include/uapi/asm-generic/sembuf.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/uapi/asm-generic/sembuf.h b/include/uapi/asm-generic/sembuf.h
> index 4cb2c13e5090..17d523f86923 100644
> --- a/include/uapi/asm-generic/sembuf.h
> +++ b/include/uapi/asm-generic/sembuf.h
> @@ -2,6 +2,8 @@
>  #define __ASM_GENERIC_SEMBUF_H
>  
>  #include <asm/bitsperlong.h>
> +#include <asm/posix_types.h>
> +#include <asm/ipcbuf.h>

I don't think you need to include <asm/posix_types.h> here,
<asm/ipcbuf.h> is necessary and enough, see
http://lkml.kernel.org/r/20170302002228.GB27132@xxxxxxxxxxxx


-- 
ldv

Attachment: signature.asc
Description: PGP signature