Re: [PATCH v3 33/49] bcache: convert to bio_for_each_segment_all_sp()

[Coly Li]

On 2017/8/8 äå4:45, Ming Lei wrote:
> Cc: linux-bcache@xxxxxxxxxxxxxxx
> Signed-off-by: Ming Lei <ming.lei@xxxxxxxxxx>

The patch is good to me. Thanks.

Acked-by: Coly Li <colyli@xxxxxxx>

> ---
>  drivers/md/bcache/btree.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c
> index 3da595ae565b..74cbb7387dc5 100644
> --- a/drivers/md/bcache/btree.c
> +++ b/drivers/md/bcache/btree.c
> @@ -422,8 +422,9 @@ static void do_btree_node_write(struct btree *b)
>  		int j;
>  		struct bio_vec *bv;
>  		void *base = (void *) ((unsigned long) i & ~(PAGE_SIZE - 1));
> +		struct bvec_iter_all bia;
>  
> -		bio_for_each_segment_all(bv, b->bio, j)
> +		bio_for_each_segment_all_sp(bv, b->bio, j, bia)
>  			memcpy(page_address(bv->bv_page),
>  			       base + j * PAGE_SIZE, PAGE_SIZE);
>  
> 


-- 
Coly Li