Re: [PATCH] ASoC: fsl_asrc: protect macro argument

[Nicolin Chen]

On Sun, Aug 06, 2017 at 11:36:57PM -0700, Stefan Agner wrote:
> Protect macro argument with parentheses to avoid ambiguity.
> This fixes a warning seen with clang:
>   warning: logical not is only applied to the left hand side of this comparison
> 
> Signed-off-by: Stefan Agner <stefan@xxxxxxxx>

Acked-by: Nicolin Chen <nicoleotsuka@xxxxxxxxx>

Thanks

> ---
>  sound/soc/fsl/fsl_asrc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/fsl/fsl_asrc.h b/sound/soc/fsl/fsl_asrc.h
> index 0f163abe4ba3..ec33dab4b909 100644
> --- a/sound/soc/fsl/fsl_asrc.h
> +++ b/sound/soc/fsl/fsl_asrc.h
> @@ -57,7 +57,7 @@
>  #define REG_ASRDOC			0x74
>  #define REG_ASRDI(i)			(REG_ASRDIA + (i << 3))
>  #define REG_ASRDO(i)			(REG_ASRDOA + (i << 3))
> -#define REG_ASRDx(x, i)			(x == IN ? REG_ASRDI(i) : REG_ASRDO(i))
> +#define REG_ASRDx(x, i)			((x) == IN ? REG_ASRDI(i) : REG_ASRDO(i))
>  
>  #define REG_ASRIDRHA			0x80
>  #define REG_ASRIDRLA			0x84
> -- 
> 2.13.3
>