Re: [PATCH V8 1/2] PCI: handle CRS returned by device after FLR

From: Sinan Kaya
Date: Sun Aug 06 2017 - 23:03:15 EST


On 8/6/2017 10:09 PM, Sinan Kaya wrote:
> + pcie_capability_read_word(dev, PCI_EXP_RTCAP, &root_cap);
> + if (root_cap & PCI_EXP_RTCAP_CRSVIS) {
> + /* don't touch the HW before waiting 100ms */
> + msleep(100);

This is obviously broken. I should have checked the capability
on the root port. I was trying to get it out before Monday.

However, I still want to hear about the preference of this
methodology.

--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.