Re: [PATCH v2 7/7] edac drivers: add MC owner check in init

From: Borislav Petkov
Date: Sat Aug 05 2017 - 01:49:52 EST


On Fri, Aug 04, 2017 at 09:48:23PM +0000, Kani, Toshimitsu wrote:
> Not sure if anyone cares, but I thought it should return with -ENODEV
> when this modules found no target, and -EBUSY when it found a target
> but it's busy. Hence, this ordering.

You can still return -EBUSY. Just do the owner check first because if
we're going to return due to ghes_edac being loaded already, we might
just as well skip the other checks as they're a pointless waste of
cycles and energy.

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--