[PATCH 4.4 89/91] scsi: snic: Return error code on memory allocation failure

From: Greg Kroah-Hartman
Date: Fri Aug 04 2017 - 19:43:50 EST


4.4-stable review patch. If anyone has any objections, please let me know.

------------------

From: Burak Ok <burak-kernel@xxxxxxxx>


[ Upstream commit 0371adcdaca92912baaa3256ed13e058a016e62d ]

If a call to mempool_create_slab_pool() in snic_probe() returns NULL,
return -ENOMEM to indicate failure. mempool_creat_slab_pool() only fails
if it cannot allocate memory.

https://bugzilla.kernel.org/show_bug.cgi?id=189061

Reported-by: bianpan2010@xxxxxxxxxx
Signed-off-by: Burak Ok <burak-kernel@xxxxxxxx>
Signed-off-by: Andreas Schaertl <andreas.schaertl@xxxxxx>
Acked-by: Narsimhulu Musini <nmusini@xxxxxxxxx>
Reviewed-by: Ewan D. Milne <emilne@xxxxxxxxxx>
Signed-off-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
Signed-off-by: Sasha Levin <alexander.levin@xxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/scsi/snic/snic_main.c | 3 +++
1 file changed, 3 insertions(+)

--- a/drivers/scsi/snic/snic_main.c
+++ b/drivers/scsi/snic/snic_main.c
@@ -584,6 +584,7 @@ snic_probe(struct pci_dev *pdev, const s
if (!pool) {
SNIC_HOST_ERR(shost, "dflt sgl pool creation failed\n");

+ ret = -ENOMEM;
goto err_free_res;
}

@@ -594,6 +595,7 @@ snic_probe(struct pci_dev *pdev, const s
if (!pool) {
SNIC_HOST_ERR(shost, "max sgl pool creation failed\n");

+ ret = -ENOMEM;
goto err_free_dflt_sgl_pool;
}

@@ -604,6 +606,7 @@ snic_probe(struct pci_dev *pdev, const s
if (!pool) {
SNIC_HOST_ERR(shost, "snic tmreq info pool creation failed.\n");

+ ret = -ENOMEM;
goto err_free_max_sgl_pool;
}