Re: [PATCH v2 05/25] mtd: nand: qcom: remove redundant chip select compatible string

From: Boris Brezillon
Date: Fri Aug 04 2017 - 03:47:32 EST


On Wed, 19 Jul 2017 17:17:53 +0530
Abhishek Sahu <absahu@xxxxxxxxxxxxxx> wrote:

> Currently the compatible âqcom,nandcsâ is being used for each
> connected NAND device to support for multiple NAND devices in the
> same bus. The same thing can be achieved by looking reg property
> for each sub nodes which contains the chip select number so this
> patch removes the use of âqcom,nandcsâ for specifying NAND device
> sub nodes.
>
> Since there is no user for this driver currently in so
> changing compatible string is safe.
>
> Signed-off-by: Abhishek Sahu <absahu@xxxxxxxxxxxxxx>

Applied to nand/next.

Thanks,

Boris

> ---
> drivers/mtd/nand/qcom_nandc.c | 26 ++++++++++++--------------
> 1 file changed, 12 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/mtd/nand/qcom_nandc.c b/drivers/mtd/nand/qcom_nandc.c
> index 8fa2f0c..110a26a 100644
> --- a/drivers/mtd/nand/qcom_nandc.c
> +++ b/drivers/mtd/nand/qcom_nandc.c
> @@ -2129,22 +2129,20 @@ static int qcom_nandc_probe(struct platform_device *pdev)
> goto err_setup;
>
> for_each_available_child_of_node(dn, child) {
> - if (of_device_is_compatible(child, "qcom,nandcs")) {
> - host = devm_kzalloc(dev, sizeof(*host), GFP_KERNEL);
> - if (!host) {
> - of_node_put(child);
> - ret = -ENOMEM;
> - goto err_cs_init;
> - }
> -
> - ret = qcom_nand_host_init(nandc, host, child);
> - if (ret) {
> - devm_kfree(dev, host);
> - continue;
> - }
> + host = devm_kzalloc(dev, sizeof(*host), GFP_KERNEL);
> + if (!host) {
> + of_node_put(child);
> + ret = -ENOMEM;
> + goto err_cs_init;
> + }
>
> - list_add_tail(&host->node, &nandc->host_list);
> + ret = qcom_nand_host_init(nandc, host, child);
> + if (ret) {
> + devm_kfree(dev, host);
> + continue;
> }
> +
> + list_add_tail(&host->node, &nandc->host_list);
> }
>
> if (list_empty(&nandc->host_list)) {