Re: [PATCH v2 4/6] dt-bindings: usb: Add documentation for NS2 IDM USB3

From: Rob Herring
Date: Thu Aug 03 2017 - 15:08:51 EST


On Wed, Jul 26, 2017 at 06:56:25PM -0400, Jon Mason wrote:
> Add documentation for IDM USB3 registers available in NS2 SoC
>
> Signed-off-by: Jon Mason <jon.mason@xxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/usb/brcm,usb3-idm.txt | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/brcm,usb3-idm.txt
>
> diff --git a/Documentation/devicetree/bindings/usb/brcm,usb3-idm.txt b/Documentation/devicetree/bindings/usb/brcm,usb3-idm.txt
> new file mode 100644
> index 000000000000..3618dbcbe890
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/brcm,usb3-idm.txt
> @@ -0,0 +1,14 @@
> +Broadcom IDM USB3 registers
> +
> +Required properties:
> +- compatible: "brcm,usb3-idm"
> +- reg: Base address and length of the USB registers
> +
> +
> +Example:
> +
> +usb3_idm: idm@67000000 {

I'm assuming these are all some misc registers in addition to the USB
controller? If this is the USB controller itself, then use generic node
names for the DT spec.

Acked-by: Rob Herring <robh@xxxxxxxxxx>

> + compatible = "brcm,usb3-idm";
> + reg = <0x67000000 0x2000>;
> +};
> +
> --
> 2.7.4
>