Re: [PATCH 0/2] serial: 8250: add support for MediaTek BTIF controller

From: Sean Wang
Date: Wed Aug 02 2017 - 13:38:03 EST


On Wed, 2017-08-02 at 20:14 +0300, Andy Shevchenko wrote:
> On Thu, 2017-08-03 at 01:05 +0800, sean.wang@xxxxxxxxxxxx wrote:
> > From: Sean Wang <sean.wang@xxxxxxxxxxxx>
> >
> > This patchset introduces the support for MediaTek BTIF controller.
> >
> > MediaTek BTIF controller is the serial interface similar to UART but
> > it
> > works only as the digital device which is mainly used to communicate
> > with
> > the connectivity module also called CONNSYS inside the SoC which could
> > be
> > mostly found on those MediaTek SoCs with Bluetooth feature.
> >
> > And the controller is made as being compatible with the 8250 register
> > layout so it tends to be integrated with existing 8250 core driver and
> > have no requirement for the modem configuration additionally such as
> > the
> > baud rate calculation and assignment.
>
>
> Why it requires a separate driver?
>
> 8250_of is for DT enabled drivers.
>

Hi, Andy

thanks for your information

the hardware is not completely identical to 8250 device,
it has extra registers belonged to platform control such as internal
loopback, dma disable/enable, sleep/wakeup setup and so on, so I create
it as a separate driver.

Sean

> >
> > Sean Wang (2):
> > dt-bindings: serial: Add MediaTek BTIF controller bindings
> > tty: serial: 8250: Add MediaTek BTIF controller on MT7622 and MT7623
> > SoC
> >
> > .../devicetree/bindings/serial/mtk-btif.txt | 26 +++
> > drivers/tty/serial/8250/8250_btif.c | 224
> > +++++++++++++++++++++
> > drivers/tty/serial/8250/Kconfig | 9 +
> > drivers/tty/serial/8250/Makefile | 1 +
> > 4 files changed, 260 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/serial/mtk-
> > btif.txt
> > create mode 100644 drivers/tty/serial/8250/8250_btif.c
> >
>