Re: [PATCH 2/2] mm: rename global_page_state to global_zone_page_state

From: Michal Hocko
Date: Wed Aug 02 2017 - 03:43:02 EST


On Tue 01-08-17 14:05:20, Andrew Morton wrote:
[...]
> WARNING: line over 80 characters
> #187: FILE: mm/page-writeback.c:1408:
> + * global_zone_page_state() too often. So scale it near-sqrt to the safety margin
>
>
> Liveable with, but the code would be quite a bit neater if we had a
> helper function for this.

I vaguely remember somebody wanted to add/consolidate a helper to
convert pages to kB as we have more of those. I wouldn't lose
sleep over "line over 80 characters" warnings in this case. Those lines
are still readable.
--
Michal Hocko
SUSE Labs