Re: [PATCH v3 05/16] ntb: ntb_test: ensure the link is up before trying to configure the mws

From: Logan Gunthorpe
Date: Tue Aug 01 2017 - 14:09:30 EST



On 01/08/17 12:07 PM, Jon Mason wrote:
> On Tue, Jul 25, 2017 at 02:57:42PM -0600, Logan Gunthorpe wrote:
>> After the link tests, there is a race on one side of the test for
>> the link coming up. It's possible, in some cases, for the test script
>> to write to the 'peer_trans' files before the link has come up.
>>
>> To fix this, we simply use the link event file to ensure both sides
>> see the link as up before continuning.
>>
>> Signed-off-by: Logan Gunthorpe <logang@xxxxxxxxxxxx>
>
> This looks like a bug fix. Assuming this is the case, I can pull it
> out, add a "Fixes" line, and add it to my bug fixes branch. Is this
> the case?

Sure, yup, if you'd like to do that I'm fine with it. Technically, I
don't think the bug can be triggered until the patches later in the
series are applied.

Thanks,

Logan