Re: [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period option showing number of samples

[Taeung Song]

Hi Arnaldo,

Sorry, I'm too late.

On 07/21/2017 08:24 PM, Arnaldo Carvalho de Melo wrote:
> Em Fri, Jul 21, 2017 at 06:41:29PM +0900, Taeung Song escreveu:
> > On 07/21/2017 04:19 AM, Arnaldo Carvalho de Melo wrote:
> > > Em Thu, Jul 20, 2017 at 06:36:55AM +0900, Taeung Song escreveu:
> > > > Currently the --show-total-period option of perf-annotate
> > > > is different from perf-report's.
>
> > > > For example, perf-report ordinarily shows period and number of samples.
>
> > > >    # Overhead       Samples        Period  Command  Shared Object   Symbol
> > > >         9.83%           102      84813704  test     test            [.] knapsack
>
> > > But this is not what this patch does, it is still doing too many things,
> > > it should first add sample to those function signatures, leaving the
> > > "meat" to a followup patch, where we will not be distracted with
> > > infrastructure needed to do what you describe in the changelog.
>
> > > I'm doing it here this time, please look at the result, later.
>   
> > ok, I'm waiting for it.
> > And if you give me some sketchy code, that's fine.
> > If you do, I'll remake this patch based on the result. :)
>
> Take a look at the acme/tmp_perf/core, that is where I got yesterday.
>
> - Arnaldo

I fetched all branch of your repository, but it don't seem to be pushed.

$ git remote get-url acme
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git

$ git branch -a | grep acme | grep tmp | grep core
  remotes/acme/tmp.perf/core
  remotes/acme/tmp_perf.core

$ git show tmp.perf/core | head -3
commit 4827c52cd001e208704ab733a389c96ae2e70e5b
Author: Andi Kleen <ak@xxxxxxxxxxxxxxx>
Date:   Fri Jul 21 12:25:57 2017 -0700

$ git show tmp_perf.core | head -3
commit 3331778eb08a50cec959da933c040bd7fbdde396
Author: Adrian Hunter <adrian.hunter@xxxxxxxxx>
Date:   Thu Jul 31 09:00:56 2014 +0300


Thanks,
Taeung