Re: [PATCH] staging: pi433: use IS_ERR to check kthread_run return value

From: Paolo Cretaro
Date: Sat Jul 22 2017 - 06:32:35 EST


On 22/07/2017 12:27, Paolo Cretaro wrote:
> Fix compiler warning: ordered comparison of pointer with integer zero

Sorry, just noticed a similar patch has been submitted a few days ago,
please ignore this patch.

Paolo

>
> Signed-off-by: Paolo Cretaro <paolocretaro@xxxxxxxxx>
> ---
> drivers/staging/pi433/pi433_if.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> index 1bc478a7f49e..79bd19123239 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -1152,7 +1152,7 @@ static int pi433_probe(struct spi_device *spi)
> device->tx_task_struct = kthread_run(pi433_tx_thread,
> device,
> "pi433_tx_task");
> - if (device->tx_task_struct < 0)
> + if (IS_ERR(device->tx_task_struct))
> {
> dev_dbg(device->dev, "start of send thread failed");
> goto send_thread_failed;
>