Re: [PATCH] firmware: Convert to using %pOF instead of full_name

From: Sudeep Holla
Date: Fri Jul 21 2017 - 12:03:10 EST




On 18/07/17 22:43, Rob Herring wrote:
> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.
>
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> Cc: Sudeep Holla <sudeep.holla@xxxxxxx>
> Cc: Mark Rutland <mark.rutland@xxxxxxx>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> ---
> drivers/firmware/arm_scpi.c | 2 +-
> drivers/firmware/psci.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/firmware/arm_scpi.c b/drivers/firmware/arm_scpi.c
> index 8043e51de897..59190c374696 100644
> --- a/drivers/firmware/arm_scpi.c
> +++ b/drivers/firmware/arm_scpi.c
> @@ -965,7 +965,7 @@ static int scpi_probe(struct platform_device *pdev)
>
> count = of_count_phandle_with_args(np, "mboxes", "#mbox-cells");
> if (count < 0) {
> - dev_err(dev, "no mboxes property in '%s'\n", np->full_name);
> + dev_err(dev, "no mboxes property in '%pOF'\n", np);
> return -ENODEV;
> }
>

(For the SCPI part)
Acked-by: Sudeep Holla <sudeep.holla@xxxxxxx>

I assume you will ask ARM-SoC guys to pick this up. Let us know if you
think otherwise.

--
Regards,
Sudeep