Re: [PATCH] net: ethernet: ti: cpsw: Push the request_irq function to the end of probe

[David Miller]

From: Grygorii Strashko <grygorii.strashko@xxxxxx>
Date: Thu, 20 Jul 2017 11:08:09 -0500

> In general patch looks good to me, but it's really unexpected to
> receive IRQs while CPSW is probing ;(

This is a poor expectation.

Boot loaders and other entities can leave the device in any state
whatsoever.

Furthermore, enabling an IRQ whose handler cannot properly execute
without crashing is wrong fundamentally.  All data structures and
state must be set up properly before the IRQ is requested.

Therefore this patch is correct and I will apply it.