Re: [PATCH 3/3] ghes_edac: add platform check to enable ghes_edac

From: Kani, Toshimitsu
Date: Thu Jul 20 2017 - 17:07:20 EST


On Thu, 2017-07-20 at 17:15 -0300, Mauro Carvalho Chehab wrote:
> Em Thu, 20 Jul 2017 19:50:03 +0000
> "Kani, Toshimitsu" <toshi.kani@xxxxxxx> escreveu:
:
> > Firmware has better knowledge about the platform and can provide
> > better RAS when implemented properly.ÂÂI agree that user
> > experiences may vary on platforms.
>
> It may have a better knowledge, when the vendor ships different BIOS
> for platforms with different motherboard silkscreens, but a lot of
> vendors just use the same BIOS on different models, with the same
> information at "Locator" and "Bank Locator" data at DMI tables,
> that don't match what's printed at the board's silkscreen.
>
> So, GHES ends by exposing wrong data. Also, such BIOS fail
> to properly expose such knowledge to drivers/userspace.

I see. Yeah, I can see such problems could be overlooked since normal
tests run just fine even if there is a mismatch in such info...

> On the discussions I had with HP, back in 2012, the idea was to tryÂ
> to have some sort of way for the GHES driver to query the BIOS
> on a reliable way, in order to get its layout, in a way
> that tools like ras-mc-ctl would properly report the memory
> configuration (with --layout) and the motherboard silkscreen
> labels (with --print-labels). Unfortunately, at least on that
> time, the discussions with HP didn't proceed.

Thanks for the info. I hope we can enable it this time around.
-Toshi