Re: [HMM 12/15] mm/migrate: new memory migration helper for use with device memory v4

From: Evgeny Baskakov
Date: Thu Jul 20 2017 - 17:05:06 EST


On 7/10/17 5:54 PM, Jerome Glisse wrote:

On Mon, Jul 10, 2017 at 05:17:23PM -0700, Evgeny Baskakov wrote:
On 7/10/17 4:43 PM, Jerome Glisse wrote:

On Mon, Jul 10, 2017 at 03:59:37PM -0700, Evgeny Baskakov wrote:
...
Horrible stupid bug in the code, most likely from cut and paste. Attached
patch should fix it. I don't know how long it took for you to trigger it.

JÃrÃme
Thanks, this indeed fixes the problem! Yes, it took a nightly run before it
triggered.

One a side note, should this "return NULL" be replaced with "return
ERR_PTR(-ENOMEM)"?
Or -EBUSY but yes sure.

JÃrÃme

Hi Jerome,

Are these fixes in already (for the alloc_chrdev_region and "return NULL" issues)? I don't see them in hmm-next nor in hmm-v24.

Can you please double check it?

Thanks!

--
Evgeny Baskakov
NVIDIA