Re: [PATCH 2/2] Staging: pi433: check error after kthread_run()

[Wolf Entwicklungen]

Reviewed-by: Marcus Wolf <linux@xxxxxxxxxxxxxxxxxxxxx>
Tested-by: Marcus Wolf <linux@xxxxxxxxxxxxxxxxxxxxx>

Am So, 16.07.2017, 16:48 schrieb Joseph Wright:
> Error should be checked with IS_ERR after calling kthread_run()
> instead of comparing the returned pointer to an int.
>
> Found by sparse warning:
>
> incompatible types for operation (<)
>     left side has type struct task_struct *tx_task_struct
>     right side has type int
>
> Signed-off-by: Joseph Wright <rjosephwright@xxxxxxxxx>
> ---
>  drivers/staging/pi433/pi433_if.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> index 46461b4..4f724a5 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -1152,7 +1152,7 @@ static int pi433_probe(struct spi_device *spi)
>  	device->tx_task_struct = kthread_run(pi433_tx_thread,
>  					     device,
>  					     "pi433_tx_task");
> -	if (device->tx_task_struct < 0)
> +	if (IS_ERR(device->tx_task_struct))
>  	{
>  		dev_dbg(device->dev, "start of send thread failed");
>  		goto send_thread_failed;
> --
> 2.9.3
>
>
>