Re: [PATCH v4 01/14] spi: qup: Enable chip select support

[Geert Uytterhoeven]

Hi Varadarajan,

On Tue, Jun 27, 2017 at 11:45 AM, Varadarajan Narayanan
<varada@xxxxxxxxxxxxxx> wrote:
> Enable chip select support for QUP versions later than v1.
> The chip select support was broken in QUP version 1. Hence
> the chip select support was removed earlier in commit
> 4a8573abe965115bc5b064401fd669b74e985258. Since the chip
> select support is functional in recent versions of QUP,
> re-enabling it for QUP versions later than v1.
>
> Signed-off-by: Sham Muthayyan <smuthayy@xxxxxxxxxxxxxx>
> Signed-off-by: Varadarajan Narayanan <varada@xxxxxxxxxxxxxx>

> --- a/drivers/spi/spi-qup.c
> +++ b/drivers/spi/spi-qup.c

> @@ -846,6 +864,9 @@ static int spi_qup_probe(struct platform_device *pdev)
>         if (of_device_is_compatible(dev->of_node, "qcom,spi-qup-v1.1.1"))
>                 controller->qup_v1 = 1;

I know it was not introduced by your patch, but the proper way is to obtain
the version flag from spi_qup_dt_match[].data.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds