Re: [PATCH 002/102] ARM: socfpga: explicitly request exclusive reset control

From: Moritz Fischer
Date: Wed Jul 19 2017 - 12:12:47 EST


On Wed, Jul 19, 2017 at 05:25:06PM +0200, Philipp Zabel wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Alan Tull <atull@xxxxxxxxxx>
> Cc: Moritz Fischer <moritz.fischer@xxxxxxxxx>
> Cc: linux-fpga@xxxxxxxxxxxxxxx
> Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
Acked-By: Moritz Fischer <mdf@xxxxxxxxxx>
> ---
> drivers/fpga/altera-hps2fpga.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/altera-hps2fpga.c b/drivers/fpga/altera-hps2fpga.c
> index 3066b805f2d07..a18ff430c9af1 100644
> --- a/drivers/fpga/altera-hps2fpga.c
> +++ b/drivers/fpga/altera-hps2fpga.c
> @@ -145,7 +145,8 @@ static int alt_fpga_bridge_probe(struct platform_device *pdev)
> of_id = of_match_device(altera_fpga_of_match, dev);
> priv = (struct altera_hps2fpga_data *)of_id->data;
>
> - priv->bridge_reset = of_reset_control_get_by_index(dev->of_node, 0);
> + priv->bridge_reset = of_reset_control_get_exclusive_by_index(dev->of_node,
> + 0);
> if (IS_ERR(priv->bridge_reset)) {
> dev_err(dev, "Could not get %s reset control\n", priv->name);
> return PTR_ERR(priv->bridge_reset);
> --
> 2.11.0
>

Thanks,

Moritz

Attachment: signature.asc
Description: PGP signature