Re: [PATCH v3 1/4] time: rtc-lib: Add rtc_show_time(const char *prefix_msg)

From: Mark Salyzyn
Date: Wed Jul 19 2017 - 10:52:12 EST


On 07/18/2017 05:00 PM, John Stultz wrote:
On Tue, Jul 18, 2017 at 3:15 PM, Mark Salyzyn <salyzyn@xxxxxxxxxxx> wrote:
Go directly to the rtc for persistent wall clock time and print.
So, first, the above doesn't seem accurate to me. You're using
getnstimeofday64() which doesn't touch the RTC.

I admit I got that backwards. I copied and pasted a line, that was supposed to read "We can not go" ... The point was that persistent or RTC clock is _not_ always available,
so we have to print suspend times when the timeofday clock is available at the points before suspend, and after suspend is complete.

The "Suspended for" message (in ms, we want us at least) albeit helpful, is performed at the bottom, and can only be reported if there is a persistent clock available. On most Android devices, it is not available.

I will post update, a better description in the primary patch, dropping the intro, printing in <epoch>.<ns> format. I asked in another thread if it would be OK to preserve the Legacy of RTC time format printing with another CONFIG parameter since we have 5 years of tooling that depends on that format.

-- Mark