Re: [PATCH v1 2/2] drm/bridge/synopsys: dsi: Register list clean up

From: Philippe CORNU
Date: Wed Jul 19 2017 - 05:12:17 EST




On 07/18/2017 03:39 PM, Laurent Pinchart wrote:
> Hi Philippe,
>
> Thank you for the patch.
>
> On Tuesday 18 Jul 2017 13:43:52 Philippe CORNU wrote:
>> This patch cleans up the Synopsys mipi dsi register list:
>> - remove unused registers
>
> Is the documentation for the DSI transmitter core public ? If not, it could be
> useful to keep unused registers for reference. That's nine lines only.
>

Hi Laurent,
And many thanks for the code review.

Unfortunately the Synopsys Documentation seems not public (I may google
more), so I will put back these registers :)

Nevertheless, the stm32 documentation is public and it is probably the
same for rockchip (and hisilicon and...), and in these public
documentations, register and bitfield names are slightly different but
register addresses and bitfield descriptions are the same...
I do not know if it makes sense or not but we may ask Synopsys to
publicly release the mipi dsi documentation...

Did you manage to get it "publicly" for the Synopsys hdmi?

>> - rename registers according to the Synopsys documentation
>> (1.30 & 1.31)
>> - fix typos
>> - re-order registers for a better coherency
>
> For the rest,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
>

Thank you
Philippe

>> Signed-off-by: Philippe CORNU <philippe.cornu@xxxxxx>
>> ---
>> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 77 +++++++++---------------
>> 1 file changed, 33 insertions(+), 44 deletions(-)
>