Re: [PATCH 2/3] mfd: syscon: atmel-smc: add helper to retrieve register layout

From: Nicolas Ferre
Date: Tue Jul 18 2017 - 05:23:48 EST


On 18/07/2017 at 11:12, Lee Jones wrote:
> On Tue, 18 Jul 2017, Lee Jones wrote:
>
>> On Tue, 11 Jul 2017, Ludovic Desroches wrote:
>>
>>> For HSMC controller, the register layout depends on the device i.e. the
>>> offset of setup, pulse, cycle, mode and timings registers is not the
>>> same. An helper is added to provide the correct register layout.
>>>
>>> Fixes: fe9d7cb22ef3 ("mfd: syscon: atmel-smc: Add new helpers to ease
>>> SMC regs manipulation")
>>> Suggested-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>
>>> Signed-off-by: Ludovic Desroches <ludovic.desroches@xxxxxxxxxxxxx>
>>> ---
>>> drivers/memory/atmel-ebi.c | 13 +++++--
>>> drivers/mfd/atmel-smc.c | 67 +++++++++++++++++++++++++-------
>>> drivers/mtd/nand/atmel/nand-controller.c | 10 +++--
>>> include/linux/mfd/syscon/atmel-smc.h | 32 ++++++++++-----
>>> 4 files changed, 92 insertions(+), 30 deletions(-)
>>
>> Applied, thanks.
>
> Apologies, it looks like this needs 2 more Acks before I can even
> consider taking it.
>
> Unapplied.

If mine is missing, here it is:

For the whole series:
Acked-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>

And I think that Alexandre seemed okay by discussing the path those
patches should take...


Thanks, bye,
--
Nicolas Ferre