Re: [PATCH net-next 11/12] net: dsa: mv88e6xxx: add Energy Detect ops

From: Vivien Didelot
Date: Mon Jul 17 2017 - 15:35:40 EST


Hi Andrew,

Andrew Lunn <andrew@xxxxxxx> writes:

> I never liked this. I think it is architecturally wrong for the switch
> to be poking around in the PHY. It should ask the PHY driver. This is
> especially true for external PHYs which might not be a Marvell PHY.

I share the same concern. However this patch is just isolating the
existing code so that we get rid of the last caps and flags and stop
writing (without reading them first) arbitrary registers.

Once this portion is moved to the PHY driver, one can remove it from
mv88e6xxx.

Thanks,

Vivien