Re: [PATCH v3 4/4] firmware: send -EINTR on signal abort on fallback mechanism

From: Luis R. Rodriguez
Date: Mon Jul 17 2017 - 12:04:43 EST


On Mon, Jul 17, 2017 at 04:00:07PM +0200, Greg KH wrote:
> On Thu, Jun 29, 2017 at 01:51:51PM -0700, Luis R. Rodriguez wrote:
> > Right now we send -EAGAIN to a syfs write which got interrupted.
> > Userspace can't tell what happened though, send -EINTR if we
> > were killed due to a signal so userspace can tell things apart.
> >
> > This is only applicable to the fallback mechanism.
> >
> > Reported-by: Martin Fuzzey <mfuzzey@xxxxxxxxxxx>
> > Signed-off-by: Luis R. Rodriguez <mcgrof@xxxxxxxxxx>
> > ---
> > drivers/base/firmware_class.c | 9 ++++++---
> > 1 file changed, 6 insertions(+), 3 deletions(-)
>
> This doesn't need to go into 4.13-final, right?

Nope.

> Can it wait for 4.14-rc1?

Yes. The bigger issue was the unexpected signals causing interruption.
This I consider a secondary and not critical issue so I did not Cc stable.

Luis