Re: [PATCH 1/1] netfilter: nf_ct_expect: fix expect removal

From: Pablo Neira Ayuso
Date: Mon Jul 17 2017 - 11:18:00 EST


Hi Jiri,

On Mon, Jul 17, 2017 at 05:06:48PM +0200, Jiri Slaby wrote:
> Commit ec0e3f01114a ("netfilter: nf_ct_expect: Add
> nf_ct_remove_expect()") introduced a helper nf_ct_remove_expect. It was
> used over the code, but one location used a wrong variable and it
> resulted in a crash in this call stack:
> -> nf_ct_expect_related_report
> -> nf_ct_remove_expect
> -> del_timer
> -> detach_if_pending
>
> Switch to the proper variable.
>
> Fixes: ec0e3f01114a
> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>

I have pushed out a similar fix from Florian:

https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git/commit/?id=36ac344e16e04e3e55e8fed7446095a6458c64e6

Thanks for the fix anyway.