Re: [PATCH v2 1/4] w1: ds1wm: fix and simplify register access

From: Greg Kroah-Hartman
Date: Mon Jul 17 2017 - 10:56:00 EST


On Fri, Jun 23, 2017 at 12:47:12PM +0200, Johannes Poehlmann wrote:
> o Replace incorrect register offsett calculation by
> direct configuration of bus_shift in mfd-cell.
> Indirect definition of address-shift by resource size
> was unobvious and should have used a binary log.
> o Make endian clean, make HW-endianness configurable.
> o Use ioread*, iowrite* instead of __raw_readb,__raw_writeb
> to also use memory-barriers when accessing HW-registers.
> We do not want reordering to happen here.
>
> Signed-off-by: Johannes Poehlmann <johannes.poehlmann@xxxxxxxxxxx>
> Acked-by: Evgeniy Polyakov <zbr@xxxxxxxxxxx>
>
> 78 6 drivers/w1/masters/ds1wm.c
> 9 0 include/linux/mfd/ds1wm.h

And again, something went wrong here :(