Re: [PATCH 1/2] thermal: int340x: constify attribute_group structures.

[Andy Shevchenko]

On Mon, 2017-07-17 at 16:04 +0530, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work
> with const attribute_group. So mark the non-const structs as const.
> 

I hope you did compile test it.

> File size before:
> ÂÂÂtext	ÂÂÂdata	ÂÂÂÂbss	ÂÂÂÂdec	ÂÂÂÂhex	
> filename
> ÂÂÂ1687	ÂÂÂÂ592	ÂÂÂÂÂÂ0	ÂÂÂ2279	ÂÂÂÂ8e7	
> int3400_thermal.o
> 
> File size After adding 'const':
> ÂÂÂtext	ÂÂÂdata	ÂÂÂÂbss	ÂÂÂÂdec	ÂÂÂÂhex	
> filename
> ÂÂÂ1751	ÂÂÂÂ528	ÂÂÂÂÂÂ0	ÂÂÂ2279	ÂÂÂÂ8e7	
> int3400_thermal.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>
> ---
> Âdrivers/thermal/int340x_thermal/int3400_thermal.c | 2 +-
> Â1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/int340x_thermal/int3400_thermal.c
> b/drivers/thermal/int340x_thermal/int3400_thermal.c
> index a9ec94e..b2ffbed 100644
> --- a/drivers/thermal/int340x_thermal/int3400_thermal.c
> +++ b/drivers/thermal/int340x_thermal/int3400_thermal.c
> @@ -104,7 +104,7 @@ static ssize_t current_uuid_store(struct device
> *dev,
> Â	NULL
> Â};
> Â
> -static struct attribute_group uuid_attribute_group = {
> +static const struct attribute_group uuid_attribute_group = {
> Â	.attrs = uuid_attrs,
> Â	.name = "uuids"
> Â};

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy