Re: [PATCH 3/3] fat: fix quoted string splits

From: Andy Shevchenko
Date: Sun Jul 16 2017 - 11:31:15 EST


On Sun, Jul 16, 2017 at 6:06 PM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> On Sun, 2017-07-16 at 16:46 +0300, Andy Shevchenko wrote:
>> On Sat, Jul 15, 2017 at 7:18 AM, Joe Perches <joe@xxxxxxxxxxx> wrote:

>> As much as it adds 'error, ' at the beginning of message. I can't
>> consider this a bad idea.
>
> Adding "error" to KERN_ERR output is unnecessary
> and if really desired, should be done by dmesg
> or equivalent.

Shouldn't be fixed in the function itself (__fat_fs_error())?

Anyway, this discussion is obviously for a separate change. The
original patch looks okay.

--
With Best Regards,
Andy Shevchenko