Re: [PATCH 2/4] ubifs: Fix unlink code wrt. double hash lookups

From: Richard Weinberger
Date: Sun Jul 16 2017 - 08:19:40 EST




Am 16.07.2017 um 14:17 schrieb Richard Weinberger:
> Geert,
>
> Am 16.07.2017 um 14:12 schrieb Geert Uytterhoeven:
>> Hi Richard,
>>
>> On Sun, Mar 19, 2017 at 9:46 PM, Richard Weinberger <richard@xxxxxx> wrote:
>>> Am 09.03.2017 um 08:04 schrieb Hyunchul Lee:
>>>>> - int n, err, type = key_type(c, key);
>>>>> - struct ubifs_znode *znode;
>>>>> + int err;
>>
>> fs/ubifs/tnc.c: In function âsearch_dh_cookieâ:
>> fs/ubifs/tnc.c:1893: warning: âerrâ is used uninitialized in this function
>>
>> None of Hyunchul's review comments below ended up in commit 781f675e2d7ec120
>> ("ubifs: Fix unlink code wrt. double hash lookups")?
>
> Oh, that was not indented.

*intentional ;)