Re: [PATCH v2 03/10] drivers base/arch_topology: frequency-invariant load-tracking support

From: Dietmar Eggemann
Date: Fri Jul 07 2017 - 12:51:37 EST


On 06/07/17 11:45, Viresh Kumar wrote:
> On 06-07-17, 10:49, Dietmar Eggemann wrote:

[...]

>> diff --git a/include/linux/arch_topology.h b/include/linux/arch_topology.h
>> index 9af3c174c03a..168104d2d2cf 100644
>> --- a/include/linux/arch_topology.h
>> +++ b/include/linux/arch_topology.h
>> @@ -4,6 +4,8 @@
>> #ifndef _LINUX_ARCH_TOPOLOGY_H_
>> #define _LINUX_ARCH_TOPOLOGY_H_
>>
>> +#include <linux/cpumask.h>
>> +
>
> You don't need a full include here, instead following will work pretty well.
>
> struct cpumask;

True. Forward declaration is sufficient here. Will change it.

[...]

> Apart from that:
>
> Reviewed-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

Thanks!