Re: [PATCH 2/2] genirq: Use is_fwnode_irqchip() directly

From: Ethan Zhao
Date: Thu Jul 06 2017 - 01:46:38 EST


Hanjunï

What branch is this patch for ? Check v4.12, failed to apply.

Thanks,
Ethan

On Thu, Jul 6, 2017 at 12:35 PM, Hanjun Guo <guohanjun@xxxxxxxxxx> wrote:
> From: Hanjun Guo <hanjun.guo@xxxxxxxxxx>
>
> is_fwnode_irqchip() already check fwnode is NULL or not,
> just use is_fwnode_irqchip() directly.
>
> Signed-off-by: Hanjun Guo <hanjun.guo@xxxxxxxxxx>
> ---
> kernel/irq/irqdomain.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
> index 1bc38fa..14a21a3 100644
> --- a/kernel/irq/irqdomain.c
> +++ b/kernel/irq/irqdomain.c
> @@ -137,7 +137,7 @@ struct irq_domain *__irq_domain_add(struct fwnode_handle *fwnode, int size,
> if (WARN_ON(!domain))
> return NULL;
>
> - if (fwnode && is_fwnode_irqchip(fwnode)) {
> + if (is_fwnode_irqchip(fwnode)) {
> fwid = container_of(fwnode, struct irqchip_fwid, fwnode);
>
> switch (fwid->type) {
> --
> 1.7.12.4
>