Re: [PATCH v2 3/3] cros_ec: Don't signal wake event for non-wake host events

From: Lee Jones
Date: Mon Jul 03 2017 - 07:46:50 EST


On Tue, 27 Jun 2017, Benson Leung wrote:

> Hi Thierry,
>
> On Tue, Feb 14, 2017 at 08:58:02PM +0100, Thierry Escande wrote:
> > From: Shawn Nematbakhsh <shawnn@xxxxxxxxxxxx>
> >
> > The subset of wake-enabled host events is defined by the EC, but the EC
> > may still send non-wake host events if we're in the process of
> > suspending. Get the mask of wake-enabled host events from the EC and
> > filter out non-wake events to prevent spurious aborted suspend
> > attempts.
> >
> > Signed-off-by: Shawn Nematbakhsh <shawnn@xxxxxxxxxxxx>
> > Signed-off-by: Thierry Escande <thierry.escande@xxxxxxxxxxxxx>
> > ---
> > drivers/mfd/cros_ec.c | 13 ++++--
> > drivers/platform/chrome/cros_ec_proto.c | 76 ++++++++++++++++++++++++++++++---
> > include/linux/mfd/cros_ec.h | 5 ++-
> > 3 files changed, 85 insertions(+), 9 deletions(-)
> >
>
> Another use of cros_ec_get_next_event was introduced in cros_ec_lpc.c since
> this patch was posted, so I went ahead and modified that too.
>
> Applied. Thanks.

No need to change anything this time, but please note the "for my own
reference" in my Ack in future. It typically means that I plan on
pushing it through the MFD tree or that it requires further discussion
(in the case that another Maintainer would prefer it go through their
tree).

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog