Re: [PATCH v5 02/12] x86/apic: Prepare for unifying the interrupt delivery modes setup

[Dou Liyang]

Hi Thomas,

At 07/03/2017 02:41 PM, Thomas Gleixner wrote:
> On Mon, 3 Jul 2017, Dou Liyang wrote:
> > At 07/03/2017 01:47 AM, Thomas Gleixner wrote:
> > > On Fri, 30 Jun 2017, Dou Liyang wrote:
> > > > +/* Init the interrupt delivery mode for the BSP */
> > > > +void __init apic_intr_mode_init(void)
> > > > +{
> > > > +	switch (apic_intr_mode_select()) {
> > > > +	case APIC_PIC:
> > > > +		apic_printk(APIC_VERBOSE, KERN_INFO
> > > > +			"Keep in PIC mode(8259)\n");
> > >
> > > Please do not proliferate that APIC_VERBOSE, KERN_INFO mess. Clean up the
> > > apic_printk() macro first. Either change printk() to pr_info() or make the
> > > printk level dependent on the APIC verbosity.
> >
> > Oops, I understood, How about the following:
> >
> > pr_info("APIC: keep in PIC mode(8259)\n");
>
> As this is once per boot, it's ok to have that information unconditionally
> printed.

Yes, I see.  will change others in the next version.

Thanks,

	dou.
> Thanks,
>
> 	tglx