Re: [PATCH] zram: constify attribute_group structures.

[Minchan Kim]

Hello,

On Mon, Jul 03, 2017 at 11:43:13AM +0530, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.

If so, how about changing all of places where not have used const
as well as zram?

Anyway, I'm okay with this.

> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>    8293	    841	      4	   9138	   23b2	drivers/block/zram/zram_drv.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>    8357	    777	      4	   9138	   23b2	drivers/block/zram/zram_drv.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>
Acked-by: Minchan Kim <minchan@xxxxxxxxxx>

Thanks.