Re: [PATCH v2] sata_rcar: fix error return code in sata_rcar_probe()

From: Gustavo A. R. Silva
Date: Fri Jun 30 2017 - 17:12:03 EST



Quoting Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>:

On 07/01/2017 12:08 AM, Gustavo A. R. Silva wrote:

platform_get_irq() returns an error code, but the sata_rcar driver
ignores it and always returns -EINVAL. This is not correct, and
prevents -EPROBE_DEFER from being propagated properly. Also,
notice that platform_get_irq() no longer returns 0 on error.

Print error message and propagate the return value of platform_get_irq
on failure.

Cc: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
Signed-off-by: Gustavo A. R. Silva <garsilva@xxxxxxxxxxxxxx>

You forgot to collect:

Acked-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>


Oh I'm sorry. Should I send v3?

Thanks
--
Gustavo A. R. Silva