Re: [PATCH 5/6] i2c: pca-platform: use device_property_read_u32

From: Wolfram Sang
Date: Fri Jun 30 2017 - 05:04:06 EST



> > - i2c->algo_data.i2c_clock = 59000;
> > + ret = device_property_read_u32(&pdev->dev, "clock-frequency",
> > + &i2c->algo_data.i2c_clock);
> > + if (ret)
> > + i2c->algo_data.i2c_clock = 59000;
>
> My idea is to get rid of legacy platform data completely.
> That's why I suggested device_* in the first place.
>
> In similar way like you did with GPIO lookup table, you may use
> PROPERTY_ENTRY*() macros in the board files.
>
> Does it make sense?

Frankly, I am not a big fan of converting board files if we cannot test
the changes.

Attachment: signature.asc
Description: PGP signature