Re: [PATCH v3] staging: lustre: lnet: remove dead code and crc32_le() wrapper

From: Greg Kroah-Hartman
Date: Fri Jun 30 2017 - 02:02:02 EST


On Fri, Jun 30, 2017 at 03:52:46AM +0000, Dmitriy Cherkasov wrote:
> After removing code which was premanently disabled with ifdefs, the
> function ksocknal_csum() becomes just a wrapper for crc32_le(). Remove
> this useless wrapper and instead call crc32_le() directly.
>
> This also resolves the following checkpatch warning which was
> triggered by the dead code:
>
> WARNING: space prohibited before semicolon
>
> Signed-off-by: Dmitriy Cherkasov <dmitriy@xxxxxxxxxxxx>
> ---
> drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h | 11 -----------
> drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib.c | 14 +++++++-------
> 2 files changed, 7 insertions(+), 18 deletions(-)

What changed from previous versions of this patch? You need to put that
information below the --- line, as documented.

v4? :)

thanks,

greg k-h