Re: [PATCH 2/4] ARM: aspeed: g5: Add USB functions to pinctrl bindings

From: Andrew Jeffery
Date: Thu Jun 29 2017 - 21:21:20 EST


On Thu, 2017-06-29 at 15:32 -0500, Rob Herring wrote:
> On Thu, Jun 29, 2017 at 03:13:24PM -0500, Rob Herring wrote:
> > On Tue, Jun 27, 2017 at 11:42:12AM +0930, Andrew Jeffery wrote:
> > > The Aspeed AST2500 SoC contains a number of USB controllers:
> > >
> > > * USB 1.1 Host Controller
> > > * USB 2.0 Host Controller (x2)
> > > * Combined USB 2.0 Virtual Hub and USB 1.1 HID Controller
> > >
> > > The controllers are exposed via two USB ports with functionality muxed
> > > as required. The following table illustrates the relationships between
> > > the ports and the controllers via the mux function names:
> > >
> > > PortÂÂ| USB VersionÂÂ| USB ModeÂÂÂÂÂ| Mux Function
> > > ------|--------------|--------------|-------------
> > > AÂÂÂÂÂ| 2.0ÂÂÂÂÂÂÂÂÂÂ| Virtual HubÂÂ| USB2AD
> > > AÂÂÂÂÂ| 2.0ÂÂÂÂÂÂÂÂÂÂ| HostÂÂÂÂÂÂÂÂÂ| USB2AH
> > > BÂÂÂÂÂ| 1.1ÂÂÂÂÂÂÂÂÂÂ| HIDÂÂÂÂÂÂÂÂÂÂ| USB11BHID
> > > BÂÂÂÂÂ| 2.0ÂÂÂÂÂÂÂÂÂÂ| DeviceÂÂÂÂÂÂÂ| USB2BD
> > > BÂÂÂÂÂ| 2.0ÂÂÂÂÂÂÂÂÂÂ| HostÂÂÂÂÂÂÂÂÂ| USB2BH
> > >
> > > > > > Signed-off-by: Andrew Jeffery <andrew@xxxxxxxx>
> > > ---
> > > ÂDocumentation/devicetree/bindings/pinctrl/pinctrl-aspeed.txt | 3 ++-
> > > Â1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > Acked-by: Rob Herring <robh@xxxxxxxxxx>
>
> Also, when you resend, use "dt-bindings: pinctrl: ..." for the subjectsÂ
> of binding patches in this series.

Will do.

Cheers,

Andrew

>
> Rob

Attachment: signature.asc
Description: This is a digitally signed message part