Re: [PATCH v2 1/1] gpio: gpio-wcove: Fix GPIO control register offset calculation

[sathyanarayanan kuppuswamy]

Hi Andy,


On 06/29/2017 05:30 AM, Andy Shevchenko wrote:
> +Cc: Hans
>
> On Mon, Jun 26, 2017 at 8:37 PM,
> <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx> wrote:
> > From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>
> >
> > According to Whiskey Cove PMIC GPIO controller specification, for GPIO
> > pins 0-12, GPIO input and output register control address range from,
> >
> > 0x4e44-0x4e50 for GPIO outputs control register
> >
> > 0x4e51-0x4e5d for GPIO input control register
> >
> > But, currently when calculating the GPIO register offsets in to_reg()
> > function, all GPIO pins in the same bank uses the same GPIO control
> > register address. This logic is incorrect. This patch fixes this
> > issue.
> > This patch also adds support to selectively skip register modification
> > for virtual GPIOs.
> >
> > In case of Whiskey Cove PMIC, ACPI code may use up 94 virtual GPIOs.
> > These virtual GPIOs are used by the ACPI code as means to access various
> > non GPIO bits of PMIC. So for these virtual GPIOs, we don't need to
> > manipulate the physical GPIO pin register. A similar patch has been
> > merged recently by Hans for Crystal Cove PMIC GPIO driver. You can
> > find more details about it in Commit 9a752b4c9ab9 ("gpio: crystalcove:
> > Do not write regular gpio registers for virtual GPIOs")
> For me (disregards to content of the patch) the question is: did we
> ever have a *working* solution looking to the bug fixes on this
> driver?!
We recently enabled this driver to handle some some requirements in IOT 
ref kit board and started seeing all these issues. Given that I am 
seeing issues related to IRQ handling, register mapping, I can safely 
say that this driver was never tested before.
> I would suggest to stop applying patches on Intel PMICs without
> Tested-by tag from independent testers.
For the patches I have sent, I have tested it in Apollo lake reference 
board and also sent this patch to testing team for verification. Only 
after confirming that it works, I sent this patch to upstream for review.
> Hans, do you have anything to add / comment on this?

--
Sathyanarayanan Kuppuswamy
Linux kernel developer