Re: [PATCH] drm/radeon: add header comment for clarification to vce_v2_0_enable_mgcg()

From: Alex Deucher
Date: Thu Jun 29 2017 - 15:25:24 EST


On Thu, Jun 29, 2017 at 1:38 PM, Gustavo A. R. Silva
<garsilva@xxxxxxxxxxxxxx> wrote:
> Add function header comment to make it clear that local variable sw_cg
> is used for debugging and it should not be removed.
>
> Addresses-Coverity-ID: 1198635
> Cc: Alex Deucher <alexdeucher@xxxxxxxxx>
> Signed-off-by: Gustavo A. R. Silva <garsilva@xxxxxxxxxxxxxx>

Applied. thanks!

Alex

> ---
> drivers/gpu/drm/radeon/vce_v2_0.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/radeon/vce_v2_0.c b/drivers/gpu/drm/radeon/vce_v2_0.c
> index fce2144..b0a43b6 100644
> --- a/drivers/gpu/drm/radeon/vce_v2_0.c
> +++ b/drivers/gpu/drm/radeon/vce_v2_0.c
> @@ -104,6 +104,10 @@ static void vce_v2_0_disable_cg(struct radeon_device *rdev)
> WREG32(VCE_CGTT_CLK_OVERRIDE, 7);
> }
>
> +/*
> + * Local variable sw_cg is used for debugging purposes, in case we
> + * ran into problems with dynamic clock gating. Don't remove it.
> + */
> void vce_v2_0_enable_mgcg(struct radeon_device *rdev, bool enable)
> {
> bool sw_cg = false;
> --
> 2.5.0
>