Re: [PATCH 12/16] switchtec_ntb: add link management

From: Logan Gunthorpe
Date: Thu Jun 29 2017 - 14:38:19 EST


On 6/29/2017 12:11 PM, Allen Hubbe wrote:

Should we only set self_partition? I think each peer should be able to set preferred speed, and negotiate down. As written here, the last peer to set the speed overrides the setting on the peer, and even that is not atomic if they race.

This function isn't actually setting the link speed. (Though I can understand the confusion from the name.) It's just reporting the slowest speed on the link between the peers for the link_is_up function. (Each port will have negotiated it's own speed).

I don't think switchtec has the ability to actually change the port speed or width. (Seeing they are negotiated on boot).

Logan