Re: [PATCH v6 00/10] serial/gpio: exar: Fixes and support for IOT2000

From: Greg Kroah-Hartman
Date: Thu Jun 29 2017 - 10:50:04 EST


On Thu, Jun 29, 2017 at 11:51:08AM +0200, Linus Walleij wrote:
> On Fri, Jun 23, 2017 at 10:09 PM, Jan Kiszka <jan.kiszka@xxxxxxxxxxx> wrote:
> > On 2017-06-21 08:29, Jan Kiszka wrote:
> >> On 2017-06-20 13:38, Linus Walleij wrote:
> >>> On Tue, Jun 20, 2017 at 10:54 AM, Jan Kiszka <jan.kiszka@xxxxxxxxxxx> wrote:
> >>>> On 2017-06-20 10:19, Linus Walleij wrote:
> >>>>> On Fri, Jun 9, 2017 at 8:33 PM, Jan Kiszka <jan.kiszka@xxxxxxxxxxx> wrote:
> >>>>>
> >>>>>> This makes the gpio-exar driver usable, which was prevented by a number
> >>>>>> of fatal bugs, and adds support for the SIMATIC IOT2040 to the 8250-exar
> >>>>>> driver and, indirectly, to gpio-exar as well. It's a cross-subsystem
> >>>>>> series, so I'm also cross-posting to the serial and gpio lists.
> >>>>>>
> >>>>>> Changes in v6:
> >>>>>
> >>>>> I merged some of the patches, that applied. Let's see if they survive
> >>>>> in linux-next, else I guess we need to fix this in the -rcs or for the next
> >>>>> kernel cycle.
> >>>>
> >>>> Weird that things did not apply. I just did a cherry-pick for all those
> >>>> 10 patches on top of 5c996b7eb52c, and that went smoothly. Please let me
> >>>> know which baseline is needed, and I will rebase.
> >>>
> >>> This was on the "devel" branch of my GPIO tree:
> >>> https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git/log/?h=devel
> >>
> >> Again, all (missing) patches applied absolutely cleanly for me, see
> >>
> >> http://git.kiszka.org/?p=linux.git;a=shortlog;h=refs/heads/queues/gpio-iot2000
> >
> > I've rebased over devel and noticed along this that you will have to
> > include "serial: uapi: Add support for bus termination" from Greg's
> > tty-next for the last patch to avoid breaking the build. Result pushed to
> >
> > http://git.kiszka.org/?p=linux.git;a=shortlog;h=refs/heads/queues/gpio-iot2000
> >
> > If you want me to resend anything, just let me know. Would be great to
> > have the remaining pieces lined up in time for the next merge window.
>
> I could just pull it in, but then I want a clear indication that Greg and
> say Andy are happy with this.
>
> The serial patches are missing Gregs explicit ACK and the platform
> patch could use Andy's ACK. The last patch adding the
> IOT2040 is so obviously out of my GPIO territory that I want
> Greg 100% aligned with this.
>
> I am sorry that it is troublesome when things cross subsystem
> boundaries, I already stretched it a bit with the things I queued
> up because it annoys me too, but this is the process we have :/

I've added my acks to the serial patches, so all should be fine for you
to take this all through your tree now.

thanks,

greg k-h