Re: [PATCH 4.4 39/46] r8152: avoid start_xmit to schedule napi when napi is disabled

[Ben Hutchings]

On Thu, 2017-06-15 at 19:52 +0200, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: hayeswang <hayeswang@xxxxxxxxxxx>
> 
> 
> [ Upstream commit de9bf29dd6e4a8a874cb92f8901aed50a9d0b1d3 ]
> 
> Stop the tx when the napi is disabled to prevent napi_schedule() is
> called.
[...]
> +	netif_stop_queue(netdev);
>  	napi_disable(&tp->napi);
[...]

netif_stop_queue() is not synchronous, so you probably need
netif_tx_disable() instead.

Ben.

-- 
Ben Hutchings
Software Developer, Codethink Ltd.