Re: [PATCH] gpiolib: fix filtering out unwanted events

From: Linus Walleij
Date: Thu Jun 29 2017 - 05:33:34 EST


On Fri, Jun 23, 2017 at 1:45 PM, Bartosz Golaszewski <brgl@xxxxxxxx> wrote:

> GPIOEVENT_REQUEST_BOTH_EDGES is not a single flag, but a binary OR of
> GPIOEVENT_REQUEST_RISING_EDGE and GPIOEVENT_REQUEST_FALLING_EDGE.
>
> The expression 'le->eflags & GPIOEVENT_REQUEST_BOTH_EDGES' we'll get
> evaluated to true even if only one event type was requested.
>
> Fix it by checking both RISING & FALLING flags explicitly.
>
> Signed-off-by: Bartosz Golaszewski <brgl@xxxxxxxx>

Patch applied for fixes.

Yours,
Linus Walleij