Re: [kernel-hardening] [RFC PATCH 1/4] Provide linux/set_memory.h

From: Daniel Borkmann
Date: Thu Jun 29 2017 - 05:03:55 EST


On 06/29/2017 08:29 AM, Michael Ellerman wrote:
Currently code that wants to use set_memory_ro() etc, needs to include
asm/set_memory.h, which doesn't exist on all arches. Some code knows
it only builds on arches which have the header, other code guards the
inclusion with an #ifdef, neither is ideal.

So create linux/set_memory.h. This always exists, so users don't need
an #ifdef just to include the header.

When CONFIG_ARCH_HAS_SET_MEMORY=y it includes asm/set_memory.h,
otherwise it provides empty non-failing implementations.

Signed-off-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx>

Looks good to me, thanks!

Acked-by: Daniel Borkmann <daniel@xxxxxxxxxxxxx>

I'm fine if Andrew or Kees picks up the bpf patch as well, I think
there shouldn't be any conflict with net-next on this one (and even
if so, then looks trivial to resolve).