Re: [PATCH] spi/bcm63xx-hspi: Fix checkpatch warnings

From: Mark Brown
Date: Wed Jun 28 2017 - 15:27:34 EST


On Tue, Jun 27, 2017 at 09:37:10PM +0530, Aravind Thokala wrote:
> This patch fixes the checkpatch.pl warnings on the driver
> file.

This isn't a good changelog, what are the warnings and why are we fixing
them? The fact that checkpatch complains isn't meaningful in and of
itself - it's OK to say that checkpatch helped identify issues but it's
not perfect and we need to understand what is being changed and why.

Attachment: signature.asc
Description: PGP signature