Re: [PATCH] selftests: ftrace: Use md5sum to take less time of checking logs

From: Steven Rostedt
Date: Wed Jun 28 2017 - 10:59:46 EST


On Wed, 28 Jun 2017 08:30:24 -0600
Shuah Khan <shuah@xxxxxxxxxx> wrote:

> On 06/28/2017 08:17 AM, Steven Rostedt wrote:
> > On Tue, 27 Jun 2017 19:28:32 +0900
> > Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:
> >
> >> Use md5sum so that it takes less time of checking
> >> trace logs update. Since busybox tail/cat takes too
> >> long time to read the trace log, this uses md5sum
> >> to check whether trace log is updated or not.
> >
> > How much faster is md5sum? I can see this causing issues in other
> > environments.
> >
> > -- Steve
>
> Sorry Steve. I pulled this into linux-ksefltest next. Are you concerned
> about any specific environments? I can try this out and see if it is a
> problem.

Yes please. I should probably do some playing too. I would like to fix
that test anyway, as it is one of the longer ones as I do a lot of
"paranoid checks". That is, I may go overboard in testing if tracing is
off or not, by checking to make sure its off using different tactics.

-- Steve