Re: [PATCH v3 4/5] i2c: pca-platform: use device managed allocations

From: Andy Shevchenko
Date: Wed Jun 28 2017 - 06:54:49 EST


On Wed, Jun 28, 2017 at 12:38 PM, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote:
>
>> > if (i2c_pca_add_numbered_bus(&i2c->adap) < 0) {
>> > - ret = -ENODEV;
>> > - goto e_adapt;
>> > + return -ENODEV;
>>
>> This is still shadows the actual error code.
>
> Nice catch. But since it fixes a seperate issue, I'd prefer an
> incremental change here.

Agreed.

--
With Best Regards,
Andy Shevchenko