RE: [PATCH 08/10] x86/hyper-v: use hypercall for remote TLB flush

From: KY Srinivasan
Date: Mon Jun 26 2017 - 17:00:51 EST




> -----Original Message-----
> From: devel [mailto:driverdev-devel-bounces@xxxxxxxxxxxxxxxxxxxxxx] On
> Behalf Of Vitaly Kuznetsov
> Sent: Monday, June 26, 2017 1:15 AM
> To: kys@xxxxxxxxxxxxxxxxxxxxxx
> Cc: olaf@xxxxxxxxx; Stephen Hemminger <sthemmin@xxxxxxxxxxxxx>;
> gregkh@xxxxxxxxxxxxxxxxxxx; jasowang@xxxxxxxxxx; x86@xxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; apw@xxxxxxxxxxxxx; kbuild-all@xxxxxx; Andy
> Lutomirski <luto@xxxxxxxxxx>; marcelo.cerri@xxxxxxxxxxxxx;
> devel@xxxxxxxxxxxxxxxxxxxxxx; leann.ogasawara@xxxxxxxxxxxxx
> Subject: Re: [PATCH 08/10] x86/hyper-v: use hypercall for remote TLB flush
>
> kbuild test robot <lkp@xxxxxxxxx> writes:
>
> > Hi Vitaly,
> >
> > [auto build test ERROR on next-20170619]
> > [cannot apply to tip/x86/core linus/master linux/master v4.12-rc6 v4.12-rc5
> v4.12-rc4 v4.12-rc7]
> > [if your patch is applied to the wrong git tree, please drop us a note to help
> improve the system]
> >
> > url:
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub
> .com%2F0day-ci%2Flinux%2Fcommits%2Fkys-exchange-microsoft-
> com%2Fx86-hyper-v-include-hyperv-only-when-CONFIG_HYPERV-is-
> set%2F20170626-
> 133601&data=02%7C01%7Ckys%40microsoft.com%7Ce74ee37675c1404b0388
> 08d4bc6b7458%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636340
> 617088680557&sdata=EkwUQ0zdqgG%2B5NkK65oz%2FSPMwPiXyUz3Otck0x
> EKGFA%3D&reserved=0
> > config: i386-randconfig-a0-06250447 (attached as .config)
> > compiler: gcc-5 (Debian 5.4.1-2) 5.4.1 20160904
> > reproduce:
> > # save the attached .config to linux build tree
> > make ARCH=i386
> >
> > All errors (new ones prefixed by >>):
> >
> > arch/x86/hyperv/mmu.c: In function 'hyperv_flush_tlb_others':
> >>> arch/x86/hyperv/mmu.c:120:32: error: passing argument 2 of
> 'native_flush_tlb_others' from incompatible pointer type [-
> Werror=incompatible-pointer-types]
> > native_flush_tlb_others(cpus, mm, start, end);
> > ^
>
> It seems we're clashing with Andy's
>
> commit a2055abe9c6789cedef29abbdaa488a087faccc3
> Author: Andy Lutomirski <luto@xxxxxxxxxx>
> Date: Sun May 28 10:00:10 2017 -0700
>
> x86/mm: Pass flush_tlb_info to flush_tlb_others() etc
>
> The fix should be simple but in case you want me to rebase/resend please
> let me know.

I can make the necessary adjustments; but I am not sure how we will
address the inter-tree dependencies.

We are planning to take this patch-set through Greg's tree.
If I make these adjustments for linux-next, Greg's tree
will be broken. Should we just wait until Greg picks up these changes in
his tree.

This patch-set also has an issue with the PCI tree.

Regards,

K. Y